charmworld proof and ingest does not properly support inheriting bundles
Bug #1263112 reported by
Richard Harding
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
charmworld |
Fix Released
|
High
|
Brad Crittenden |
Bug Description
Bundles should support inheritance and we've hit one that currently fails. I'm attaching the bundle file to the bug. It's a complicated openstack demo that a dev was working on.
Related branches
lp:~bac/charmworld/1263112
- Juju Gui Bot: Approve (continuous-integration)
- Charmworld Developers: Pending requested
-
Diff: 409 lines (+184/-66)8 files modifiedcharmworld/jobs/ingest.py (+30/-6)
charmworld/jobs/tests/test_ingest.py (+6/-6)
charmworld/jobs/tests/test_proof.py (+24/-25)
charmworld/lib/proof.py (+3/-0)
charmworld/lib/tests/test_proof.py (+22/-1)
charmworld/views/api/proof.py (+11/-2)
charmworld/views/tests/test_proof.py (+86/-25)
requirements.txt (+2/-1)
Changed in charmworld: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Additional info from Rick via IRC:
"""
right, the general thing is that charmworld ingest seems to support it
and we shared some logic with the deployer that supports it
but when the proof bits were written we had no examples and I didn't understand it so kind of skipped the feature
so any changes should just be in the proof bits in charmworld or the proof library in order to allow ingest to accept the inheritance based bundles
and I found one from hazmat that's attached to the bug as a narly example. If that one ingests then everything should be good
I believe that demo file works with the deployer, so we need to make sure it'll ingest
"""