charmworld proof and ingest does not properly support inheriting bundles

Bug #1263112 reported by Richard Harding
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
charmworld
Fix Released
High
Brad Crittenden

Bug Description

Bundles should support inheritance and we've hit one that currently fails. I'm attaching the bundle file to the bug. It's a complicated openstack demo that a dev was working on.

Related branches

Revision history for this message
Richard Harding (rharding) wrote :
Revision history for this message
Brad Crittenden (bac) wrote :

Additional info from Rick via IRC:

"""
right, the general thing is that charmworld ingest seems to support it

and we shared some logic with the deployer that supports it

but when the proof bits were written we had no examples and I didn't understand it so kind of skipped the feature

so any changes should just be in the proof bits in charmworld or the proof library in order to allow ingest to accept the inheritance based bundles

and I found one from hazmat that's attached to the bug as a narly example. If that one ingests then everything should be good

I believe that demo file works with the deployer, so we need to make sure it'll ingest
"""

Changed in charmworld:
assignee: nobody → Brad Crittenden (bac)
status: Triaged → In Progress
Revision history for this message
Juju Gui Bot (juju-gui-bot) wrote :

Fix committed into lp:charmworld at revision 476, scheduled for release in charmworld, milestone Unknown

Changed in charmworld:
status: In Progress → Fix Committed
Revision history for this message
Brad Crittenden (bac) wrote :

If you look at staging you see that the modified version of the test bundle has been ingested:

http://staging.jujucharms.com/search?search_text=complicated&op=

The required modification was changing "False" to False to pass proof. We may want to change proof to accept "[tT]rue" and "[fF]alse" in quotes.

Changed in charmworld:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.