InsertFromSelect should accept a list of column names

Bug #1263081 reported by Kiall Mac Innes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Kiall Mac Innes
Icehouse
Fix Released
Undecided
Kiall Mac Innes

Bug Description

InsertFromSelect should accept a list of column names

See review comments on https://review.openstack.org/#/c/63208/

Tags: database
Revision history for this message
Kiall Mac Innes (kiall) wrote :

SQLA 0.8.3+ has an InsertFromSelect built in - http://docs.sqlalchemy.org/en/rel_0_8/core/dml.html#sqlalchemy.sql.expression.Insert.from_select

We're still pinned, along with the rest of OpenStack to SQLAlchemy>=0.7.8,<=0.7.99.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63400

Changed in designate:
assignee: nobody → Kiall Mac Innes (kiall)
status: Confirmed → In Progress
tags: added: database
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/63400
Committed: https://git.openstack.org/cgit/stackforge/designate/commit/?id=f3df3795991636698f15848007367907d65e13fe
Submitter: Jenkins
Branch: master

commit f3df3795991636698f15848007367907d65e13fe
Author: Kiall Mac Innes <email address hidden>
Date: Fri Dec 20 12:11:09 2013 +0000

    Specify column names during the PowerDNS backends InsertFromSelect's

    Closes-Bug: 1263081
    Closes-Bug: 1262837
    Change-Id: I635c0767df792c5980ad345fe2714aae046060f3

Changed in designate:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.