Cannot delete an IN_PROGRESS stack

Bug #1262012 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Jason Dunsmore

Bug Description

Since multi-engine was merged it is no longer possible to delete a stack which is create/update IN_PROGRESS:

$ heat delete config1
ERROR: Stack config1 already has an action (CREATE) in progress.

This is a regression, any in-progress create or update needs to be halted so that the lock can be taken for a delete. This would result in having to wait for the stack timeout for deleting some stacks which are known to be bad.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63002

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/67971

Changed in heat:
milestone: icehouse-2 → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/67971
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=07884448fed64badcf8922c01c1ea044462584b7
Submitter: Jenkins
Branch: master

commit 07884448fed64badcf8922c01c1ea044462584b7
Author: Jason Dunsmore <email address hidden>
Date: Mon Jan 20 15:02:34 2014 -0600

    Add a new ThreadGroupManager class

    Introduce a ThreadGroupManager class to manage active ThreadGroups for
    engine services and move the thread-related EngineService methods to
    ThreadGroupManager. This will make it easier for multiple engine
    services to manage thread groups.

    Partial-Bug: #1262012
    Change-Id: I1ce7785021726c274a294ef402b036540d395a29

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/63002
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=42f788b56f02454cfa43e7801b62edeb50359c00
Submitter: Jenkins
Branch: master

commit 42f788b56f02454cfa43e7801b62edeb50359c00
Author: Jason Dunsmore <email address hidden>
Date: Mon Dec 16 14:16:26 2013 -0600

    Allow an in-progress stack to be deleted

    Since multi-engine was merged, it is no longer possible to delete a
    stack which is create/update IN_PROGRESS. This re-introduces that
    ability.

    If the current engine has an active stack lock, stop any active
    threads, remove the lock, and delete the stack. If another engine has
    the active stack lock, send an RPC command to the remote engine to stop
    any active threads and remove the lock, and then delete the stack
    locally. If no engines have the an active stack lock, acquire the lock
    and delete the stack.

    Closes-Bug: #1262012
    Change-Id: I188e43ad88b98da7d1a08269189aaefa57c36df2

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.