puppet module path does not get set to puppet.conf for second puppet run

[Pradeep Kilambi]

The puppet modules via apt get installed under /usr/share/puppet/modules. But the module path is not set appropriately. It gets passed into the setup.pp's puppet apply. But for non aio installs user needs to run it for site.pp and the module path is not set at that point.

[Mark T. Voelker (mvoelker)]

Hmm…that path should be part of the default module path, and from a glance at configprint that looks to be the case (this is a compressed_ha scenario):

root@build:~/puppet_openstack_builder/install-scripts# puppet config print modulepath
/etc/puppet/modules:/usr/share/puppet/modules
root@build:~/puppet_openstack_builder/install-scripts#

[Chris Ricker (chris-ricker)]

Issue is that we use passenger, not standalone puppetmaster, so the compiled in default module path doesn't apply

Our /etc/puppet/puppet.conf (which does apply) currently has:

[master]
# These are needed when the puppetmaster is run by passenger
# and can safely be removed if webrick is used.
modulepath = /etc/puppet/modules

[Mark T. Voelker (mvoelker)]

The issue here is that we're calling up a default in the puppet-puppet module, which for some strange reason doesn't include the usual two paths in modulepath. This should be a relatively simple fix.

[Mark T. Voelker (mvoelker)]

Hmm...I take that back: I think we are sending a param, and are setting it with only a single path.

https://github.com/CiscoSystems/puppet-coi/blob/havana/manifests/profiles/puppet/master.pp#L48

[Mark T. Voelker (mvoelker)]

Pull to fix:

https://github.com/CiscoSystems/puppet-coi/pull/28