creating sheepdog volume from image fails

[Joe Rouvier]

When sheepdog is the backend, attempts to create a volume from an image fail with the error:

cinder.volume.flows.create_volume [req-AAAAA BBBBB] Failed to copy image CCCCC to volume: DDDD, error: qemu-img: Could not open '<open GreenPipe '<fd:12>', mode 'w+b' at 0x35d6ef0>': No such file or directory

This would be corrected by the following change:

index 21bda61..1168a60 100644
--- a/cinder/volume/drivers/sheepdog.py
+++ b/cinder/volume/drivers/sheepdog.py
@@ -112,7 +112,7 @@ class SheepdogDriver(driver.VolumeDriver):
             # see volume/drivers/manager.py:_create_volume
             self._delete(volume)
             # convert and store into sheepdog
- image_utils.convert_image(tmp.name, 'sheepdog:%s' % volume['name'],
+ image_utils.convert_image(tmp, 'sheepdog:%s' % volume['name'],
                                       'raw')
             self._resize(volume)

[Joe Rouvier (j4e)]

A merge request has been submitted:

https://github.com/openstack/cinder/pull/6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/65566

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/65566
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=dfefeda9cf87a8a4109c3f4e35feb5ee1d9eedff
Submitter: Jenkins
Branch: master

commit dfefeda9cf87a8a4109c3f4e35feb5ee1d9eedff
Author: john-griffith <email address hidden>
Date: Wed Jan 8 16:21:41 2014 -0700

    Fix sheepdog copy_image_to_volume method

    The sheepdog driver fails when trying to
    create volume from image due to a bug in
    SheepdogDriver.copy_image_to_volume.

    The utils.convert method is being passed the
    tempfile object, but should only be passed
    the name of the tempfile.

    Change-Id: I6b261d29895bf9c2c30b2d95d74e5be58b8e9b10
    Closes-Bug: 1261941