directory creation is not needed prior to calling mount_point.mount()

Bug #1261905 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Sushil Kumar

Bug Description

https://github.com/openstack/trove/blob/master/trove/guestagent/volume.py#L41 creates the directory before calling the mounting method

Directory creation is useless as the method VolumeMountPoint.mount at https://github.com/openstack/trove/blob/master/trove/guestagent/volume.py#L133

would create the directory in the absence of existing path, so no need of an extra step. :)

Would prefer to remove this extra parcel.

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62754

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/62754
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=3344661b18f55bb997ab435169cabeba97d55976
Submitter: Jenkins
Branch: master

commit 3344661b18f55bb997ab435169cabeba97d55976
Author: Sushil Kumar <email address hidden>
Date: Tue Dec 17 20:38:28 2013 +0000

    Removes directory creation prior to _tmp_mount

    Reasons:
    - Directory creation is included in VolumeMountPoint.mount method.
    - No need to repeat the steps before calling the mount method.

    Changes:
    - Removed directory creation prior to calling _tmp_mount.
    - Test updated to reduce number of utils.execute,
      as we now have one less call in the code.

    Change-Id: I5136f1ce537c919ff2e009cd617f33925d955e88
    Closes-Bug: #1261905

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.