_write_temp_mycnf_with_admin_account modifies the permissions of the MYSQL_BASE_DIR without any reasons

Bug #1261854 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Sushil Kumar

Bug Description

https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L711
modifies the permission of MYSQL_BASE_DIR (= "/var/lib/mysql").

This has no relevance, as the path is nowhere used in the method.

This line should be removed, as the same has got no relevance.

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62724

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/62724
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=14f119cba7de269dc1a12734c17f7e316e12d4ee
Submitter: Jenkins
Branch: master

commit 14f119cba7de269dc1a12734c17f7e316e12d4ee
Author: Sushil Kumar <email address hidden>
Date: Tue Dec 17 18:02:40 2013 +0000

    Removes privilege modification for MYSQL_BASE_DIR

    Reasons:
    - No usage of the path MYSQL_BASE_DIR in the method.
    - 2 Files used in the method are both in different locations
      /tmp/my.cnf.tmp and /etc/mysql/my.cnf
    - It is just a hanging line of code without any reasons.

    Changes:
    - privilege modification line removed from code.

    Change-Id: I676f7faaf1e7b78c5d0f9f79b622f230ae2b9740
    Closes-Bug: #1261854

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.