Hacking checks should prevent virt drivers accessing each other's code
Bug #1261842 reported by
Daniel Berrange
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
There have been 2 bugs where the bare metal driver is accessing libvirt private code
https:/
https:/
This kind of mistake could be prevented using a custom pep8 hacking rule for Nova.
Arguably the same could be said of other files outside the nova/virt directory - they shouldn't access private virt driver code directly - only go via the public virt driver API
Changed in nova: | |
milestone: | none → icehouse-3 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-3 → 2014.1 |
To post a comment you must log in.
Patch to implement a hacking rule addition. Not submitted to Gerrit, since we'd obviously require the bare metal driver bugs to be fixed before we can enforce this.