Need set compute driver's flag capabilities correctly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
ChangBo Guo(gcb) |
Bug Description
1.Back ground:
Class ComputeDriver, base of all compute drivers, has dictionary capabilities
to indicate if the compute driver implements some functions. The 'supports_recreate'
flag needs the driver to support the evacuate operation. The 'has_imagecache' flag
needs the driver to implement the 'manage_
check this with capabilities[
[3]directly.
2. Problems:
1)Docker does not currently support these two functions, so the capabilities flags
should not be set.[4]
2)Baremetal only set 'has_imagecache', there is code path leading KeyError.
Need set capabilities explicitly to avoid this.[5]
3.Solution:
Set or unset compute driver's capabilities explicitly.
[1] https:/
[2] https:/
[3] https:/
[4] https:/
[5] https:/
Changed in nova: | |
status: | New → In Progress |
assignee: | nobody → ChangBo Guo (guochbo) |
importance: | Undecided → Low |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → icehouse-2 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-2 → 2014.1 |
Reviewed: https:/ /review. openstack. org/59258 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=6a932aebbc6 8989485d4867920 a6a6bbf536f6c6
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6a932aebbc68989 485d4867920a6a6 bbf536f6c6
Author: Chang Bo Guo <email address hidden>
Date: Sat Nov 30 01:04:06 2013 -0800
Remove docker's unsupported capabilities
The 'supports_recreate' flag needs the driver to support the evacuate image_cache' method. Docker does not currently support these
operation. The 'has_imagecache' flag needs the driver to implement the
'manage_
two functions, so the capabilities flags should not be set.
Partial-Bug: #1261636
Change-Id: I191d0d8cd35aec e52462c0477f2d8 9897bb762c1