GTG

Adding a tag with '&' causes ExpatError.

Bug #1261458 reported by aslam karachiwala
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
High
Parin Porecha

Bug Description

v. 0.3.r1334~ubuntu13.04.1

1. Right-click an existing task and select 'Modify tags...'
2. Enter a new tag: a&b
3. Click 'Add/remove tags'.
4. Double click the task to open it.
5. Dialog open saying, "GTG 0.3.1 has crashed..."
6. Clicking 'Details' shows the trace.
7. Click 'Ignore error.'
8. Double-click the task again, it doesn't open.
9. Normal functioning requires closing and re-launching GTG.

Adding a tag by editing the task in task editor also raises the same error

Trace:
Traceback (most recent call last):
  File "/usr/share/gtg/GTG/gtk/editor/taskviewserial.py", line 157, in unserialize
    element = xml.dom.minidom.parseString(data)
  File "/usr/lib/python2.7/xml/dom/minidom.py", line 1931, in parseString
    return expatbuilder.parseString(string)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 940, in parseString
    return builder.parseString(string)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 223, in parseString
    parser.Parse(string, True)
ExpatError: not well-formed (invalid token): line 1, column 18

Would help to specify the character restrictions for tags in the docs.

Revision history for this message
aslam karachiwala (akwala) wrote :
Nimit Shah (nimit-svnit)
Changed in gtg:
status: New → Confirmed
importance: Undecided → High
milestone: none → 0.3.2
Changed in gtg:
assignee: nobody → Parin Porecha (parinporecha)
description: updated
Revision history for this message
Parin Porecha (parinporecha) wrote :

Pushed revision 1335 containing the fix for this bug.

Now, you can create tags with '&' in it.
However, it has caused Bug #1261772. I'm trying to find out the cause for it

Changed in gtg:
status: Confirmed → Fix Committed
Revision history for this message
aslam karachiwala (akwala) wrote :

Confirming fix. Thanks!

Jeff Fortin Tam (kiddo)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.