Wrong code comment

Bug #1261388 reported by Kneib François
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Yade
Fix Released
Low
Unassigned

Bug Description

Hi,

I think there is a mistake into the code comment : Ip2_FrictMat_FrictMat_FrictPhys.cpp line 40.
According the the documentation [https://yade-dem.org/doc/formulation.html#normal-stiffness] and the code, it seems that this Ip2 uses :

Li = 2 * Ri (i is a sphere)

as a typical length to transform Young modulus into stiffness :

Ki = Li * Ei = 2 * Ri * Ei

But into the code comment (L40), it's written : "(Ri.Ei/2) is the stiffness of a contact point on sphere "i", and to my mind it should be "(Ri.Ei*2) ..."

Don't you think so ?

Revision history for this message
Bruno Chareyre (bruno-chareyre) wrote : Re: [Yade-dev] [Bug 1261388] [NEW] Wrong code comment

You are right. Feel free to fix.

Changed in yade:
status: New → Fix Committed
Changed in yade:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.