should handle boolean string parameters through cells sync_instances API
Bug #1261287 reported by
Ken'ichi Ohmichi
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Ken'ichi Ohmichi |
Bug Description
If specifying false string ("False") as "deleted" parameter of cells sync_instances API like the following, nova considers it as True.
On the other hand, nova can consider false string as false in the case of "on_shared_storage" parameter of evacuate API.
That behavior seems API inconsistency.
Changed in nova: | |
assignee: | nobody → Ken'ichi Ohmichi (oomichi) |
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
importance: | Undecided → Medium |
Changed in nova: | |
milestone: | none → icehouse-2 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-2 → 2014.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/62300 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=7239c9673d4 c4387d6f6e4fddc c26712afabe85b
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7239c9673d4c438 7d6f6e4fddcc267 12afabe85b
Author: Ken'ichi Ohmichi <email address hidden>
Date: Tue Dec 17 00:19:48 2013 +0900
Add boolean convertor to cells sync_instances API
cells sync_instances API contains "deleted" as the parameter, and the
parameter should be boolean. There are the other boolean parameters
such as "on_shared_storage" of evacuate API, they can be passed with
either boolean or string(e.g. "True").
For the consistency of whole Nova APIs, this patch adds boolean conv-
ertors to cells sync_instances API.
Change-Id: I4776539cfd723f 302d10350757e1c 341384c9ba2
Closes-Bug: #1261287