Symbol set names are not translatable

[Kris]

The names of symbol sets (AIGA symbol signs, Word balloons, etc.) in the symbol dialog (shift+ctrl+Y) can not be translated.

[jazzynico (jazzynico)]

I'm going to take a look.

[jazzynico (jazzynico)]

Fix committed revision 12946.

[su_v (suv-lp)]

JFYI - r12946 seems to break out-of-source builds on OS X. I vaguely recall from bug #1170803 that syntax based on $(wildcard …) is not full portable, though the issue could be unrelated... seems that the paths get mangled with out-of-source build:

In-src-tree build:
=============
(…)
Making all in symbols
 cd ../.. && /bin/sh /Volumes/magenta/mp-trunk/src/inkscape-repo/mptrunk-x11-check/build-aux/missing automake-1.14 --foreign share/symbols/Makefile
configure.ac:213: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:213: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:213: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
share/symbols/Makefile.am:5: warning: wildcard $(srcdir: non-POSIX variable name
share/symbols/Makefile.am:5: (probably a GNU make extension)
share/symbols/Makefile.am:10: warning: wildcard $(srcdir: non-POSIX variable name
share/symbols/Makefile.am:10: (probably a GNU make extension)
share/symbols/Makefile.am:13: warning: foreach i,$(symbols_i18n: non-POSIX variable name
share/symbols/Makefile.am:13: (probably a GNU make extension)
 cd ../.. && /bin/sh ./config.status share/symbols/Makefile
config.status: creating share/symbols/Makefile
./i18n.py ././AigaSymbols.svg ././BalloonSymbols.svg ././FlowSymbols.svg ././LogicSymbols.svg ././MapSymbols.svg > ./symbols.h
Making all in templates
(…)

out-of-src-tree build:
=================
(…)
Making all in symbols
 cd ../../.. && /bin/sh /Volumes/magenta/mp-trunk/src/inkscape-repo/bugfix/build-aux/missing automake-1.14 --foreign share/symbols/Makefile
configure.ac:213: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:213: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:213: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
share/symbols/Makefile.am:5: warning: wildcard $(srcdir: non-POSIX variable name
share/symbols/Makefile.am:5: (probably a GNU make extension)
share/symbols/Makefile.am:10: warning: wildcard $(srcdir: non-POSIX variable name
share/symbols/Makefile.am:10: (probably a GNU make extension)
share/symbols/Makefile.am:13: warning: foreach i,$(symbols_i18n: non-POSIX variable name
share/symbols/Makefile.am:13: (probably a GNU make extension)
 cd ../.. && /bin/sh ./config.status share/symbols/Makefile
config.status: creating share/symbols/Makefile
../../../share/symbols/i18n.py ../../../share/symbols/../../../share/symbols/AigaSymbols.svg ../../../share/symbols/../../../share/symbols/BalloonSymbols.svg ../../../share/symbols/../../../share/symbols/FlowSymbols.svg ../../../share/symbols/../../../share/symbols/LogicSymbols.svg ../../../share/symbols/../../../share/symbols/MapSymbols.svg > ../../../share/symbols/symbols.h
Traceback (most recent call last):
  File "../../../share/symbols/i18n.py", line 9, in <module>
    doc = minidom.parse(filename)
  File "/Volumes/magenta/mp-trunk/quartz/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/dom/minidom.py", line 1918, in parse
    return expatbuilder.parse(file)
  File "/Volumes/magenta/mp-trunk/quartz/Library/F...

[su_v (suv-lp)]

Could you review & test proposed fix as attached?

[su_v (suv-lp)]

SImplified patch (tested successfully with in-src and out-of-src build).

[jazzynico (jazzynico)]

> Could you review & test proposed fix as attached?

Works perfectly with in-src-tree build.
Out-src-tree build test in progress...

[jazzynico (jazzynico)]

Out-src-tree build test successful too!
Fixed in the trunk revision 12947.

Thanks for the patch, ~suv!

[su_v (suv-lp)]

Fix typo in ignore list (r12946)

[jazzynico (jazzynico)]

Simplified patch and typo fix committed revision 12948.
Thanks again!

[Martin Owens (doctormo)]

So the fix takes translations for the symbols from inkscape's internal pot file? I was hoping we could find a solution that could extract the translations from the svg files themselves, but I guess that would be hard to do right.

[su_v (suv-lp)]

r12946 breaks GTK3 builds - build error:

  CXX ui/dialog/symbols.o
../../src/ui/dialog/symbols.cpp: In member function ‘void Inkscape::UI::Dialog::SymbolsDialog::get_symbols()’:
../../src/ui/dialog/symbols.cpp:542: error: ‘str_has_suffix’ is not a member of ‘Glib’
../../src/ui/dialog/symbols.cpp:542: error: ‘str_has_suffix’ is not a member of ‘Glib’
make[3]: *** [ui/dialog/symbols.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

[su_v (suv-lp)]

Proposed fix for GTK3 builds - please test.

[jazzynico (jazzynico)]

str_has_suffix error fixed revision 12949.

@Martin - All the translatable content in the share folder (filters, patterns, palettes, templates and symbols) is extracted to a header file with a Python script, and then the .h file is used to populate the inkscape.pot template.

[jazzynico (jazzynico)]

Revision 12950 replaces my far too stupid patch in 12949 with ~suv's patch (I must take a rest...).