Invalid method defined init_engine in trove/tests/util/__init__.py

[Sushil Kumar]

There is an invalid method definition in trove/tests/util/__init__.py

    def init_engine(user, password, host):
        return create_engine("mysql://%s:%s@%s:3306" %
                             (user, password, host),
                             pool_recycle=1800, echo=True)
        self.engine = engine
        self.use_flush = use_flush

This method has got statements after return which are of no use.

Those extra statements should be removed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/62235

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/62235
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=2ea9a4fedc4d21bea790052d6eb3172badd570bf
Submitter: Jenkins
Branch: master

commit 2ea9a4fedc4d21bea790052d6eb3172badd570bf
Author: Sushil Kumar <email address hidden>
Date: Sun Dec 15 15:26:20 2013 +0000

    Cleans the method init_engine

    Reasons:
    - init_engine contains code after return statement,
      which is of no use.
    - the statements used are also of no purpose as
      they use unavailable variables.

    Change:
    - Code lines after return statement are removed.

    Change-Id: Ibfd1f0de1d9200c0f1a724345fa9ef744da1ce7e
    Closes-Bug: #1261169

[Thierry Carrez (ttx)]

Should not be marked FixReleased until released in a milestone.