VMware: replace mox to mock in test_vmware_vmdk

Bug #1261097 reported by Subbu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Wishlist
Vipin Balachandran

Bug Description

As part of overall cinder effort to move unit tests to mock fix unit tests in test_vmware_vmdk file.

Tags: drivers vmware
Changed in cinder:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62217

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/62217
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6846ed79c31f02bbacf48d2bb22e7128549c56f0
Submitter: Jenkins
Branch: master

commit 6846ed79c31f02bbacf48d2bb22e7128549c56f0
Author: Subramanian Neelakantan <email address hidden>
Date: Wed Feb 5 17:39:05 2014 +0530

    VMware: changing volumeops tests from mox to mock.

    Changing unit tests implementation of volumeops to mock. In the process
    also moving all these unit tests into a separate class for better
    test organization.

    Partial-Bug: #1261097
    Change-Id: I08b2341b22ed9c8f63930a2c73a9737cbe7ef540

Changed in cinder:
importance: Low → Wishlist
Revision history for this message
Vipin Balachandran (vbala) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/117443

Changed in cinder:
assignee: Subbu (subramanian-neelakantan) → Vipin Balachandran (vbala)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/155300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/155300
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b22a2dc8469520099fde7478a9fcb9cd74e7a622
Submitter: Jenkins
Branch: master

commit b22a2dc8469520099fde7478a9fcb9cd74e7a622
Author: Vipin Balachandran <email address hidden>
Date: Wed Feb 11 18:16:16 2015 +0530

    VMware: Refactor initialize_connection unit tests

    This patch refactors initialize_connection unit tests
    to use mock.

    Partial-Bug: #1261097
    Change-Id: I9a1a50526d038c0a9c17d0015f00b4bf27d68131

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/237543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/237543
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f13777da65f57e49aa109661a588c6ee3695144d
Submitter: Jenkins
Branch: master

commit f13777da65f57e49aa109661a588c6ee3695144d
Author: Vipin Balachandran <email address hidden>
Date: Mon Oct 19 12:25:54 2015 +0530

    VMware: Unit test refactoring

    Some of the unit tests use mox instead of mock. Also, there are
    cases where a single test tests multiple cases and methods. This
    patch refactors the unit tests for the following methods in the
    vmdk module to fix these issues:

    * get_volume_stats
    * _verify_volume_creation
    * create_volume
    * delete_volume
    * _get_extra_spec_disk_type
    * _get_disk_type
    * create_snapshot
    * delete_snapshot

    There will be follow-up patches to fix the remaining unit tests.

    Partial-bug: #1261097
    Change-Id: I17b1c0df4e13bf9900a2fe8d37ff5297a8e7486e

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249797

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/249797
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4a91bf6b63ef987e4847dbf6356cc4aff980182c
Submitter: Jenkins
Branch: master

commit 4a91bf6b63ef987e4847dbf6356cc4aff980182c
Author: Vipin Balachandran <email address hidden>
Date: Wed Nov 25 19:04:48 2015 +0530

    VMware: Replace mox with mock

    This patch replaces usages of mox with mock in the VMDK driver unit tests.
    It also refactors the unit tests for copy_volume_to_image so that those
    tests test only a single method.

    Closes-Bug: #1261097
    Change-Id: I50925a3aed1df12a283e9ec20f2bc2add1aad162

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0b2

This issue was fixed in the openstack/cinder 8.0.0.0b2 development milestone.

Changed in cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.