Fix "party stoppers" in Master Sync
Bug #1260838 reported by
RJ Skerry-Ryan
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
High
|
Owen Williams |
Bug Description
Here's a list of party-stoppers in the master sync support:
* Deck passthrough activates
* Track ejected
* Beatgrid on track cleared or becomes empty (0BPM)
* Vinyl control activated on follower (when master is already VC enabled)
* Rogue script sets 'master' and 'pfl' to 0.
We should gracefully hand-off from master or do something reasonable when these things happen.
Changed in mixxx: | |
milestone: | none → 1.12.0 |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in mixxx: | |
assignee: | nobody → Owen Williams (ywwg) |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
If the user has passthrough active, and then they try to enable sync mode, should we:
1. disable passthrough, or
2. disallow the enable change?
When vinyl control is active, we disable vinyl control -- this makes sense because we're handing off from vinyl control to sync control. But for passthrough, disabling passthrough would cause a complete change in audio processing. So for now I'm picking 2 and disabling enabling passthrough.
As a protection, if somehow the user forces sync on, I will still disable passthrough. But the idea is to head it off at the pass in synccontrol: :slotSyncModeCh angeRequest