checkbox-gui code needs a good cleanup
Bug #1260625 reported by
Brendan Donegan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox GUI (Legacy) |
Fix Released
|
Low
|
Brendan Donegan |
Bug Description
Due to the deadlines involved in delivering the new UI code, it was a bit messy at the end. Lots of commented out code and several build warnings are amongst the sins. We should clean this up a bit while we have the bandwidth to do so.
Related branches
lp:~brendan-donegan/checkbox/checkbox-gui-cleanup
- Zygmunt Krynicki (community): Approve
-
Diff: 835 lines (+56/-264)18 files modifiedcheckbox-gui/checkbox-gui/listmodel.cpp (+0/-6)
checkbox-gui/checkbox-gui/qml/ManualInteractionDialog.qml (+0/-6)
checkbox-gui/checkbox-gui/qml/ResumeView.qml (+2/-2)
checkbox-gui/checkbox-gui/qml/RunManagerListView.qml (+0/-1)
checkbox-gui/checkbox-gui/qml/RunManagerSuiteDelegate.qml (+0/-1)
checkbox-gui/checkbox-gui/qml/RunManagerTestDelegate.qml (+0/-13)
checkbox-gui/checkbox-gui/qml/RunManagerView.qml (+0/-10)
checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml (+0/-38)
checkbox-gui/checkbox-gui/qml/SuiteSelectionDelegate.qml (+48/-48)
checkbox-gui/checkbox-gui/qml/SuiteSelectionView.qml (+1/-6)
checkbox-gui/checkbox-gui/qml/TestSelectionListView.qml (+0/-6)
checkbox-gui/checkbox-gui/qml/TestSelectionSuiteDelegate.qml (+0/-2)
checkbox-gui/checkbox-gui/qml/WarningDialog.qml (+0/-8)
checkbox-gui/checkbox-gui/qml/WelcomeView.qml (+0/-1)
checkbox-gui/checkbox-gui/qml/checkbox-gui.qml (+0/-3)
checkbox-gui/checkbox-gui/testitem.cpp (+1/-3)
checkbox-gui/checkbox-gui/testitem.h (+1/-1)
checkbox-gui/gui-engine/gui-engine.cpp (+3/-109)
Changed in checkbox: | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Brendan Donegan (brendan-donegan) |
tags: | added: new-ui |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
affects: | checkbox → checkbox-gui |
Changed in checkbox-gui: | |
milestone: | none → 0.18 |
Changed in checkbox-gui: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.