nova-manage useage exposes action-args

[Scott Devoid]

The nova-manage command exposes the action_args options during the usage output for command.

E.g.
$ nova-manage network modify -h
usage: nova-manage network modify [-h] [--fixed_range <x.x.x.x/yy>]
                                  [--project <project name>] [--host <host>]
                                  [--disassociate-project]
                                  [--disassociate-host]
                                  [action_args [action_args ...]]

positional arguments:
  action_args

<snip>

This can cause confusion as users naturally expect there to be more "actions" on commands like "modify". Even in straightforward cases, this positional argument leaks into usage.

$ nova-manage db version -h
usage: nova-manage db version [-h] [action_args [action_args ...]]

positional arguments:
  action_args

Please consider suppressing documentation on action_args. In addition, expose the __doc__ strings for these functions, which is done in the nova command.

[Sahid Orentino (sahid-ferdjaoui)]

Actually I don't know what action_args is used for?
https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1312

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/74503

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/74503
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=62c869d2375009190c5358636fd7de2ab9d194a5
Submitter: Jenkins
Branch: master

commit 62c869d2375009190c5358636fd7de2ab9d194a5
Author: Juan Manuel Olle <email address hidden>
Date: Tue Feb 18 17:47:57 2014 -0300

    Remove action-args from nova-manage help

    During help [action_args [action_args ...]] could be
    confusing for users

    $ nova-manage network list -h
    usage: nova-manage network list [-h]
             [action_args [action_args ...]]

    Because of that action_args is set to "SUPPRESS" from the help

    Change-Id: I0fdc480724d3b59a8eebb2d294f324441c5e46b2
    Closes-Bug: #1260538