Savanna should not send private keys to the cloud user

[Alexander Ignatov]

Due unknown reasons (legacy code I think) Savanna sends private keys for cloud users (ubuntu, fedora, ec2-user) during cluster provisioning. For example now it can be seen in Heat templates generated by http://paste.openstack.org/show/54693/

[Alexander Ignatov (aignatov)]

We need just to send public keys only to VMs

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/62200

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/62200
Committed: https://git.openstack.org/cgit/openstack/savanna/commit/?id=29eba90566d4599172b3a569948b9613b2f3c6c0
Submitter: Jenkins
Branch: master

commit 29eba90566d4599172b3a569948b9613b2f3c6c0
Author: Alexander Ignatov <email address hidden>
Date: Sun Dec 15 00:39:29 2013 +0400

    Removed cloud user private key pushing to nodes

      Due to security considerations we should not send private key of cloud
      users to VMs. This is mostly needed for Heat provisioning logic, where
      heat templates must not have secret keys written in user-data section.
      With this change Heat templates will look like as follows:
      http://paste.openstack.org/show/55008/

      Savanna old provisioning engine is also cleared from pushing private keys
      to nodes.

      Changed behaviour of wait_until_accessible method. Now it checks
      ~/.ssh/authoriszed_keys instead of ~/.ssh/id_rsa

      (NOTE: don't worry about code duplication in both engines). The common
      part of provisioning code will be extracted soon as part of bug
      https://bugs.launchpad.net/savanna/+bug/1259170

    Change-Id: Ibe42cf6fc756ffc92bfc3fe520f4cecb732d858b
    Closes-Bug: #1260357