Error in getting the major and minor version of hypervisor from tuple

Bug #1260178 reported by Aditi Raveesh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Aditi Raveesh

Bug Description

The utils method get_major_minor_version was being used to get the major and minor versions from the hypervisor version. This was used to determine whether the version is compatible with the required version, to then set the device_id on a vm record during vm creation.
This method was required by the feature: https://review.openstack.org/#/c/55117/

The method is not really required, because the hypervisor version in xen is always in the form of a tuple. This can directly be used, instead of using a utils method.

This fix will include:
- Removing the utils get_major_minor_version method
- Correctly handling the hypervisor version as a tuple

Aditi Raveesh (aditirav)
Changed in nova:
assignee: nobody → Aditi Raveesh (aditirav)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/61679

Changed in nova:
status: New → In Progress
Changed in nova:
importance: Undecided → Low
Aditi Raveesh (aditirav)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/61679
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=09cca5fc0c9dd02832421b26acbf691df0c39936
Submitter: Jenkins
Branch: master

commit 09cca5fc0c9dd02832421b26acbf691df0c39936
Author: Aditi Raveesh <email address hidden>
Date: Wed Dec 18 10:33:01 2013 +0530

    Setting the xen vm device id on vm record

    Currently, while setting the device_id, the hypervisor
    version is being incorrectly handled since the method
    get_major_minor_version expects either an int, float,
    or string format. However, the xen hypervisor
    version is stored in the session product_version as a tuple.
    This fix correctly uses the version to set the appropriate
    device_id on the vm record. Also, removing the method
    get_major_minor_version as it is not needed anymore.

    Closes-bug: #1260178

    Change-Id: I6b1353cdb7cc856b34f02e3d3679c142ba032533

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.