auto scaling policy doen't give a nice error on a bogus groupname

Bug #1260111 reported by Angus Salkeld
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Angus Salkeld

Bug Description

If you manually give the groupname on the autoscaling policy the signal will produce a weird exception:

curl: (6) Could not resolve host: curl; Name or service not known
<ErrorResponse><Error><Message>The request processing has failed due to an internal error:Remote error: ResourceFailure AttributeError: 'NoneType' object has no attribute 'name'
[u'Traceback (most recent call last):\n', u' File "/home/asalkeld/work/heat/heat/openstack/common/rpc/amqp.py", line 462, in _process_data\n **args)\n', u' File "/home/asalkeld/work/heat/heat/openstack/common/rpc/dispatcher.py", line 172, in dispatch\n result = getattr(proxyobj, method)(ctxt, **kwargs)\n', u' File "/home/asalkeld/work/heat/heat/engine/service.py", line 60, in wrapped\n return func(self, ctx, *args, **kwargs)\n', u' File "/home/asalkeld/work/heat/heat/engine/service.py", line 644, in resource_signal\n stack[resource_name].signal(details)\n', u' File "/home/asalkeld/work/heat/heat/engine/resource.py", line 850, in signal\n raise failure\n', u"ResourceFailure: AttributeError: 'NoneType' object has no attribute 'name'\n"].</Message><Code>InternalFailure</Code><Type>Server</Type></Error></ErrorResponse>

Revision history for this message
Angus Salkeld (asalkeld) wrote :

We should at least produce a more meaningful error.

Changed in heat:
importance: Undecided → Low
assignee: nobody → Angus Salkeld (asalkeld)
milestone: none → icehouse-2
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/61607

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/61607
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=15e2fed46a25663d779849480321caba4d67eece
Submitter: Jenkins
Branch: master

commit 15e2fed46a25663d779849480321caba4d67eece
Author: Angus Salkeld <email address hidden>
Date: Mon Dec 16 11:41:46 2013 +1100

    Improve autoscaling error message

    If we can't find the autoscaling group name produce a more
    meaningful error message.

    Change-Id: Id7ecae67c9ca8eca0c45b365e9a58caee212c2c9
    Closes-bug: #1260111

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.