NetApp cDOT driver should split clone from snapshot after creation

[Valeriy Ponomaryov]

If we try delete snapshot, which is busy, it won't be deleted and won't get proper response

How to reproduce:

1) create share
2) create snapshot from 1) share
3) create share from snapshot
4) try delete snapshot

Result: it is not deleted and we get 200 Ok
Status of snapshot stay the same.

But we expect proper response from server, that it is busy and we can not do nothing with this.

p.s It was reproduced with prototype of NetApp driver, current LVM driver does not set 'busy' state to snapshot.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169364

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169364
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d37f44f04a166b7b8cd3219ece6bace91e4bab0e
Submitter: Jenkins
Branch: master

commit d37f44f04a166b7b8cd3219ece6bace91e4bab0e
Author: Clinton Knight <email address hidden>
Date: Sun Mar 15 19:56:58 2015 -0400

    cDOT driver should split clone from snapshot after creation

    When the cDOT driver receives a create_share_from_snapshot command,
    it clones the share/flexvol from the specified snapshot in the
    parent share/flexvol. But if the resulting clone is not split
    from its parent, the snapshot remains busy and may not be deleted.
    This is resolved by starting a clone split operation anytime a
    clone is created.

    During the split operation, which usually completes within
    seconds, the snapshot remains busy. This patch detects that
    condition in the snapshot delete path and waits up to a minute
    for the busy condition to clear.

    Change-Id: I44bac106f7f7a1acc968c1d9a526dcef85f657b7
    Closes-Bug: #1259988