Volume type or nova flavor extra_spec containing '/' can't be deleted

[Eric Harney]

Written based on Nova bug 1256119.

It is possible to set an extra spec for a volume type containing a '/' that then cannot be deleted.

$ cinder type-create test
+--------------------------------------+------+
| ID | Name |
+--------------------------------------+------+
| ff8b49fb-3883-428e-a942-61fa34633c23 | test |
+--------------------------------------+------+
$ cinder type-key test set 'a/b=c'
$ cinder extra-specs-list
+--------------------------------------+------+----------------+
| ID | Name | extra_specs |
+--------------------------------------+------+----------------+
| ff8b49fb-3883-428e-a942-61fa34633c23 | test | {u'a/b': u'c'} |
+--------------------------------------+------+----------------+
$ cinder --debug type-key test unset 'a/b'

...snip...

REQ: curl -i http://192.168.122.100:8776/v2/b3d6b9a5b8f04df08bf33714fe99d52a/types/ff8b49fb-3883-428e-a942-61fa34633c23/extra_specs/a/b -X DELETE -H "X-Auth-Project-Id: demo" -H "User-Agent: python-cinderclient" -H "Accept: application/json" -H "X-Auth-Token: MI...ITF"

DEBUG:cinderclient.client:
REQ: curl -i http://192.168.122.100:8776/v2/b3d6b9a5b8f04df08bf33714fe99d52a/types/ff8b49fb-3883-428e-a942-61fa34633c23/extra_specs/a/b -X DELETE -H "X-Auth-Project-Id: demo" -H "User-Agent: python-cinderclient" -H "Accept: application/json" -H "X-Auth-Token: MI...ITF"

RESP: [404] CaseInsensitiveDict({'date': 'Tue, 10 Dec 2013 22:07:01 GMT', 'content-length': '52', 'content-type': 'text/plain; charset=UTF-8'})
RESP BODY: 404 Not Found

The resource could not be found.

DEBUG:cinderclient.client:RESP: [404] CaseInsensitiveDict({'date': 'Tue, 10 Dec 2013 22:07:01 GMT', 'content-length': '52', 'content-type': 'text/plain; charset=UTF-8'})
RESP BODY: 404 Not Found

The resource could not be found.

ERROR: Not found (HTTP 404)

[Shree Duth Awasthi (shreeduth-awasthi)]

Shall we go the other way round by not allowing the "/" to be included in volume type extra_spec ?

Though I believe that Matt Riedemann suggestion is good enough for nova.

Please correct, if my understanding is incorrect.

[Mike Perez (thingee)]

Yes, we should be checking that it's alphanumeric, dashes, periods, underscores and spaces as nova is.

[Rushi Agrawal (rushiagr)]

Skipped reading the first line of bug description, that there is already a bug registered against Nova.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/68477

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68477
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5ec6f8f8e8b88f48300e66369840c2fafd06f4c5
Submitter: Jenkins
Branch: master

commit 5ec6f8f8e8b88f48300e66369840c2fafd06f4c5
Author: Alejandro Emanuel Paredes <email address hidden>
Date: Wed Jan 22 15:19:19 2014 -0500

    Extra_spec containing '/' can't be deleted

    This patch validates the keys of the extra specs
    before setting them.
    This will make possible to remove those keys.
    It allows alphanumeric characters, underscores,
    periods, colons and hyphens.

    Change-Id: Ic2e5d7ce42c8ecb7ee45cd168bd008035fd4bbdf
    Closes-Bug: #1259711