image unhandled when delete VM

Bug #1259462 reported by hougangliu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Sahid Orentino

Bug Description

In nova /compute/manager.py :def _delete_instance()
There is a line "image = instance['image_ref']", but the variable 'image' is not used in this method any more.

In addition, when deleting a vm with state "shelved" or "shelved-offloaded", the vm's snapshot like ‘shelved image’ should also be removed. I think delete a vm should handle this case

Changed in nova:
status: New → Triaged
importance: Undecided → Low
Changed in nova:
assignee: nobody → sahid (sahid-ferdjaoui)
Revision history for this message
Sahid Orentino (sahid-ferdjaoui) wrote :

I'm going to push a small fix to remove the not necessary variable "image" and then push something with tests about shelved vm to close this bug.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/61462

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/61462
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=48729259c570d73d7c35228718ecc4e9bb258e36
Submitter: Jenkins
Branch: master

commit 48729259c570d73d7c35228718ecc4e9bb258e36
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Wed Dec 11 15:28:32 2013 +0000

    Shelve: The snapshot should be removed when delete instance.

    When deleting a vm with state "shelved" or "shelved-offloaded",
    the vm's snapshot like ‘shelved image’ should also be removed.

    Change-Id: Ie9b0f8dec8f85351ef188f70e0fe9414e332aafe
    Closes-Bug: #1259462

Changed in nova:
status: In Progress → Fix Committed
tags: added: havan-backport-potential
Changed in nova:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.