XenAPI: dd into config drive must use direct IO

Bug #1259163 reported by Bob Ball
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Bob Ball

Bug Description

There is a theoretical race condition between dd and VBD.unplug in the nova compute VM where we are using non-direct IO meaning the device might not be synced before we attempt to unplug.

This _may_ be related to the frequency of the following message seen in the guest.
[17765.790561] vbd vbd-51744: 16 Device in use; refusing to close

Tags: xenserver
Bob Ball (bob-ball)
Changed in nova:
importance: Undecided → Medium
assignee: nobody → Bob Ball (bob-ball)
tags: added: xenserver
Changed in nova:
milestone: none → icehouse-2
Bob Ball (bob-ball)
description: updated
Changed in nova:
status: New → In Progress
Bob Ball (bob-ball)
Changed in nova:
importance: Medium → Low
description: updated
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/60808
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5b0c8f0b967c4e610f19c946aae9d99b090967ba
Submitter: Jenkins
Branch: master

commit 5b0c8f0b967c4e610f19c946aae9d99b090967ba
Author: Bob Ball <email address hidden>
Date: Mon Dec 9 13:27:17 2013 +0000

    XenAPI: Use direct IO for writing config drive

    If you don't use direct IO when writing to the device, the unplug
    immediately following this may not succeed as the device may still
    be in use.

    Also add a sync to ensure the device is not being used at the point
    of unplug.

    Closes-bug: 1259163

    Change-Id: I68f09835648b36772a7839af9718123a4c60734f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.