Music directories can be added twice, via Preferences and via Browse menu

Bug #1259077 reported by jus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Max Linke

Bug Description

Tested with latest Github master on OSX 10.8

Steps to reproduce:
* Goto Preferences>Library> Add a music folder
* Goto the Browse pane in the Library, navigate to the folder you added before and choose "Add to Library"
* Go to the Preferences to find the same folder got added, just with other file path visible

Expected result:
Adding the folder a 2nd time should be rejected

Tags: library
Revision history for this message
jus (jus) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hm, we need to canonicalize all directories when comparing them.

Changed in mixxx:
milestone: none → 1.12.0
importance: Undecided → Low
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

(though since these are different mount points and not symlinks I'm not sure if QDir can canonicalize them)

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

Could we hash (MD5sum) the directory listings then compare those?

Max Linke (max-linke)
Changed in mixxx:
assignee: nobody → Max Linke (max-linke)
Max Linke (max-linke)
Changed in mixxx:
status: New → In Progress
Revision history for this message
Max Linke (max-linke) wrote :

are they really different mount points? I found that it was a bug in directorydao.isChildDir. I fixed in in https://github.com/mixxxdj/mixxx/commit/15c0d41e04e903bff73906f2323d090d07a7bb75

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7224

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.