Duplicate test case 'test_exceed_append_location' in unit/test_quota.py

[Feilong Wang]

Duplicate test case name in unit/test_quota.py, see https://github.com/openstack/glance/blob/master/glance/tests/unit/test_quota.py#L193

    def test_exceed_append_location(self):
        image_size = 10
        max_images = 2
        quota = image_size * max_images
        self.config(user_storage_quota=quota)
        image = self._get_image(image_size=image_size,
                                location_count=max_images)
        self.assertRaises(exception.StorageQuotaFull,
                          image.locations.append,
                          {'url': 'file:///a/path', 'metadata': {}})

    def test_exceed_append_location(self):
        image_size = 10
        max_images = 2
        quota = image_size * max_images
        self.config(user_storage_quota=quota)
        image = self._get_image(image_size=image_size,
                                location_count=max_images)
        self.assertRaises(exception.StorageQuotaFull,
                          image.locations.insert,
                          0,
                          {'url': 'file:///a/path', 'metadata': {}})

[Feilong Wang (flwang)]

And I would like to see the test case name 'test_iadd_location' can be refactored, see https://github.com/openstack/glance/blob/master/glance/tests/unit/test_quota.py#L179 because I didn't see any justification to use 'iadd'

[Feilong Wang (flwang)]

Steve, thanks for working on this. Do you think the #1 comments is reasonable?

[Feilong Wang (flwang)]

Pls skip my comment #1, I think the 'iadd' is for __iadd__, sorry for the confusion.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60740
Committed: http://github.com/openstack/glance/commit/9adee277017b9ae4cd600052b6af537427305ede
Submitter: Jenkins
Branch: master

commit 9adee277017b9ae4cd600052b6af537427305ede
Author: Steve Kowalik <email address hidden>
Date: Mon Dec 9 16:14:56 2013 +1100

    Refactor StorageQuotaFull test cases in test_quota

    There were two test cases in test_quota that shared the same name, but
    did almost the same thing. After a bit of digging, it looked like most
    of the test cases did the almost same thing, so I refactored the common
    bits and fixed the test case name duplication.

    Partial-Bug: #1259036
    Change-Id: I828eea570d358d98520c7201454c03ba174a35ad