Phantom column in library table

[jus]

With the latest git master, there is a ambiguous column "17" in the library table.
By purpose?

[Owen Williams (ywwg)]

I see this too.

[jus (jus)]

Probably the KEY_ID column from the database. We already display the natural key of a track in the `KEY`column - using the key format selected by the user. So no need to display the KEY_ID column.

[jus (jus)]

This removed the column for me

diff --git a/src/library/mixxxlibraryfeature.cpp b/src/library/mixxxlibraryfeature.cpp
index 3badd62..236df27 100644
--- a/src/library/mixxxlibraryfeature.cpp
+++ b/src/library/mixxxlibraryfeature.cpp
@@ -44,7 +44,6 @@ MixxxLibraryFeature::MixxxLibraryFeature(QObject* parent,
             << "library." + LIBRARYTABLE_FILETYPE
             << "library." + LIBRARYTABLE_TRACKNUMBER
             << "library." + LIBRARYTABLE_KEY
- << "library." + LIBRARYTABLE_KEY_ID
             << "library." + LIBRARYTABLE_DATETIMEADDED
             << "library." + LIBRARYTABLE_BPM
             << "library." + LIBRARYTABLE_BPM_LOCK

[RJ Skerry-Ryan (rryan)]

Yea, it's the KEY_ID column. We need it for the KEY column though.

So we should add the KEY_ID to the internal column list in all the TableModels.

[RJ Skerry-Ryan (rryan)]

If anyone wants to do this, it's super easy:

Add "LIBRARYTABLE_KEY_ID" to the set of keys that return true for every isColumnInternal() method in src/library.

[k bashar (k.bashar)]

i have just send a pull request on this bug. would anyone please review this?

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7217