tests still fail when libvirt not installed

Bug #1258603 reported by Phil Day
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Phil Day

Bug Description

https://review.openstack.org/#/c/60052/1 fixed a problem with fake libvirt driver by adding default arguments to Connection class, but the tests still fail sometimes because the default value for uri is only accepted if a global in the fake driver is true:

 allow_default_uri_connection

Tests only fail sometimes, so I guess this global is affected by other tests

Phil Day (philip-day)
Changed in nova:
importance: Undecided → High
assignee: nobody → Phil Day (philip-day)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60586

Changed in nova:
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: libvirt testing
Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

The libvirt.allow_default_uri_connection is set False in one of test, but it is not set back to True. The above test fail when it was executed after that one.

The fix is to set this value to True after the test test_openAuth_can_refuse_None_uri is executed in nova/tests/virt/libvirt/test_fakelibvirt.py

The attached patch might solve this issue.

Revision history for this message
Phil Day (philip-day) wrote :

Was a duplicate of https://bugs.launchpad.net/nova/+bug/1258553, for which a fix has been committed

Changed in nova:
status: In Progress → Fix Committed
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.