unimplemented get_floating_ips_by_fixed_address in neutronv2/api.py

Bug #1258380 reported by Mathew Odden
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Unassigned

Bug Description

get_floating_ips_by_fixed_address is currently hard coded to return an empty list in the nova neutron API.

https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L770

This is because of a change that was a work around for some issues back in the Folsom / Grizzly releases.

https://github.com/openstack/nova/commit/c0709bdd82c83e16cab6ed854d2ef873eb775473

This should be implemented or removed if it isn't needed any longer (dead code)

Tags: network
Mathew Odden (locke105)
tags: added: network
Changed in nova:
status: New → Confirmed
Revision history for this message
Matt Riedemann (mriedem) wrote :

There are several things that need to be removed in here also (see the notes from vish) but looks like they require us to bump the version on the network rpc api, but that's probably not a huge deal.

https://github.com/openstack/nova/blob/master/nova/network/floating_ips.py

I'll open a new bug to follow up on that.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/60603
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b884fe8e2ad740e151c906d64e47f8a27ab567b7
Submitter: Jenkins
Branch: master

commit b884fe8e2ad740e151c906d64e47f8a27ab567b7
Author: Lance Bragstad <email address hidden>
Date: Fri Dec 6 19:38:09 2013 +0000

    Raise NotImplementedError in NeutronV2 API

    Remove unused code in nova.network.neutronv2 that returns an empty
    list. Instead of just returning an empty list, let's be more explicit
    and raise a NotImplementedError. This will be more descriptive if
    someone is trying to use this part of the NeutronAPI.

    Commit 45e92d4703 contains the changes to use the db layer instead of
    the network rpcapi.

    Change-Id: I2a9ada8186fd4165c7fceb15965055b5793e6e2c
    Closes-Bug: 1258380

Changed in nova:
status: Confirmed → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.