Don't spellcheck outside of strings [$125]

Bug #1258257 reported by Danielle Foré
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Scratch
Confirmed
Wishlist
Unassigned

Bug Description

If the spellcheck plugin is enabled, it shouldn't check outside of strings.

If that's not possible, we should automatically turn off spellchecking when we know we're editing a code file

Tags: bounty

Related branches

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

it is not possible to tell spell checker to check only in strings.

Changed in scratch:
status: New → In Progress
importance: Undecided → Low
milestone: none → isis-beta1
assignee: nobody → Mario Guerriero (mefrio-g)
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

I'm pretty sure Gedit does this. I recall it advertising spell check only in comments, but strings are probably supported too.

This might be it: https://git.gnome.org/browse/gedit/commit/?h=gnome-3-8&id=412ef504a4d00b046fbb62501f6baa6da5ed2099

Changed in scratch:
importance: Low → Wishlist
status: In Progress → Confirmed
milestone: isis-beta1 → none
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

A branch to only check spelling in non-source-code files was merged, so this bug is partially solved. The remaining part is a wishlist item, thus I'm untargeting it from Isis beta milestones.

Revision history for this message
meese (meese) wrote :

Gedits approach to this is to just include a modified version of GTK Spell. Would this be an acceptable solution for scratch? And possibly convert it to Vala too?

Revision history for this message
Cody Garver (codygarver) wrote :
summary: - don't spellcheck outside of strings
+ don't spellcheck outside of strings [$125]
tags: added: bounty
Changed in scratch:
assignee: Mario Guerriero (mefrio-g) → nobody
Revision history for this message
Zisu Andrei (matzipan) wrote :

Hey guys,

IDEs like the ones from JetBrains (IntelliJ etc) do spell checking in code as well, this is to ensure that for example, you don't make a typo in a variable or function name.

I would say this is not a bug.

Revision history for this message
Zisu Andrei (matzipan) wrote :

I think I get what the purpose of the issue is, though. I was mistaken.

I guess a separate issue needs to be opened to somehow make it work better with variable and function names (ie. know how to decompose camelCaseVariables and underscore_variables and how to report back spelling issues). And it would only care about definitions, not usages, because you only care of a misspelling when you define something.

summary: - don't spellcheck outside of strings [$125]
+ Don't spellcheck outside of strings [$125]
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.