XenAPI: wait_for_vhd_coalesce times out when garbage collector still running

[Bob Ball]

In some runs, particular stress tests, the GC may run for more than 25 seconds. The current timeout is after 5*5 seconds and so this needs to be increased.

2013-12-05 10:57:51.024 DEBUG nova.compute.manager [req-24f4e285-4e0d-48f6-8c19-793fd2735488 ListImageFiltersTestJSON-tempest-987533830-user ListImageFiltersTestJSON-tempest-987533830-tenant] [instance: 37b86681-9225-4786-82f2-f4110697fda6] Cleaning up image 6ccd3d8d-1918-4bbc-b448-af7ebb50ce33 from (pid=25289) decorated_function /opt/stack/nova/nova/compute/manager.py:321
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/opt/stack/nova/nova/compute/manager.py", line 317, in decorated_function
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] *args, **kwargs)
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/opt/stack/nova/nova/compute/manager.py", line 2427, in snapshot_instance
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] task_states.IMAGE_SNAPSHOT)
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/opt/stack/nova/nova/compute/manager.py", line 2458, in _snapshot_instance
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] update_task_state)
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 250, in snapshot
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] self._vmops.snapshot(context, instance, image_id, update_task_state)
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 729, in snapshot
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] post_snapshot_callback=update_task_state) as vdi_uuids:
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] return self.gen.next()
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 782, in _snapshot_attached_here_impl
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] original_parent_uuid)
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 2044, in _wait_for_vhd_coalesce
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] raise exception.NovaException(msg)
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6] NovaException: VHD coalesce attempts exceeded (5), giving up...
2013-12-05 10:57:51.024 TRACE nova.compute.manager [instance: 37b86681-9225-4786-82f2-f4110697fda6]

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60253
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=270d4f1d6b100c802a65b31d35e406528aa7fd27
Submitter: Jenkins
Branch: master

commit 270d4f1d6b100c802a65b31d35e406528aa7fd27
Author: Bob Ball <email address hidden>
Date: Thu Dec 5 14:35:14 2013 +0000

    XenAPI: Monitor the GC when coalescing

    Add a new host plugin to monitor whether the garbage collector is running.
    This is then used by the wait_for_vhd_coalesce function to know whether
    waiting any more is likely to produce the expected results.

    Increased the number of times we loop waiting for coalesce as the loop
    now has knowledge that something is still happening.

    DocImpact
    Change to parameter default.

    Change-Id: Idcc0738945bd1aee8cdb52c9cfabd798f85c31db
    Closes-bug: 1258169