The response is incorrect while creating volume metadata

Bug #1258004 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
huangtianhua

Bug Description

1.Create metadata for a volume with the request body:
{"metadata":{
             "key1": "value1",
             "KEY1": "value2"
}}

2.The server accept it, and return the response body, as bellow:
{"metadata":{
             "key1": "value1",
             "KEY1": "value2"
}}

3.Get the metadata of the volume, the server returned:
{"metadata":{
             "key1": "value1"
}}

4.I find that case ignore in cinder, so the server just add one metadata for the volume

5.So i think the response body should return the one which the server added when create action:
  {"metadata":{
             "key1": "value1"

}}

Changed in cinder:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60147

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/60147
Committed: http://github.com/openstack/cinder/commit/b91e6e31ece12d5b1204680aa0a912e3b9569f3b
Submitter: Jenkins
Branch: master

commit b91e6e31ece12d5b1204680aa0a912e3b9569f3b
Author: huangtianhua <email address hidden>
Date: Thu Dec 5 11:15:11 2013 +0800

    Fixes case insensitive for resp body

    Create metadata for a volume with key-value set, which key in uppercase
    and lowercase(e.g.{"key": "v1", "KEY": "V1"), the server accept the
    request and return the key-value set {"key": "v1", "KEY": "V1"}. But the
    server just add one metadata because the server is not case sensitive.

    The patch will modify the resp body with the one which the server added.

    update_all has the same ploblem.

    Fixes errors on v2 unittest without difficulty.

    DocImpact
    Closes-Bug: #1258004

    Change-Id: Ic337c0a351ac234493e1d73b86ba87520f32289a

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.