When editing flavor extra spec, it's creating a new entry instead of updating the current one

Bug #1257882 reported by Gustavo Knüppe
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Nicolas Simonds

Bug Description

In Horizon, when editing a flavor extra spec, in case of you change the key name, horizon will not update the selected extra spec but create a new one.

STEPS TO REPRODUCE:
1. login on Horizon
2. select "admin" TAB
3. Select "Flavors" option
4. for a given flavor, click on "More" and select "View extra spec"
5. Create and extra expec with key "test1" value "value1"
6. in the created entry line, click on "edit" button
7. change key to "test2" and value "value2"

You' see a new entry will be created and both will be kept.

As a solution, the field that contain the "key" should not accept changes when editing extra spec.
This way only the value is updated properly and no new entry is created.

Revision history for this message
chenhaiq (chenhaiq) wrote :

nova api can not update "key". I will remove the key field in edit dialog.

If any one want to update "key", he/she has to delete it and create a new one.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60446

Changed in horizon:
assignee: nobody → chenhaiq (chenhaiq)
status: New → In Progress
Changed in horizon:
assignee: chenhaiq (chenhaiq) → Nicolas Simonds (nicolas.simonds)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/60446
Committed: http://github.com/openstack/horizon/commit/ba49aab68d6a726d55ae7ec24084be0554d8c279
Submitter: Jenkins
Branch: master

commit ba49aab68d6a726d55ae7ec24084be0554d8c279
Author: chenhaiq <email address hidden>
Date: Fri Dec 6 16:44:26 2013 +0800

    Hide key field in edit Flavor Extra Specs dialog

    Nova allow user to add key/value to flavor, but its api is only
    able to update value according to key.

    Hide the key field in edit dialog, in order to avoid confusion.
    User can delete and create new one when need to update "key".

    Change-Id: Ibd13bfe8a3832d019d16a39b40f643b860e3c612
    Closes-Bug: #1257882

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.