Settings should be an icon on the toolbar instead of a tab
Bug #1257871 reported by
Victor Thompson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu File Manager App |
Fix Released
|
Undecided
|
Victor Thompson | ||
Ubuntu Terminal App |
Fix Released
|
Undecided
|
Victor Thompson |
Bug Description
Ideally the Settings page should be accessible from a toolbar button rather than a separate tab. Tabs should be used to divide app content in to separate views of similar information--things such as Settings and About views should be selected in a sub item of the overall current view. A toolbar item is ideal for this task.
Related branches
lp:~vthompson/ubuntu-filemanager-app/move-settings-page-to-toolbar
- Michael Spencer: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Carlos Jose Mazieri: Approve
-
Diff: 103 lines (+25/-13)3 files modifiedFolderListPage.qml (+8/-1)
debian/control (+2/-1)
ubuntu-filemanager-app.qml (+15/-11)
lp:~vthompson/ubuntu-terminal-app/move-settings-to-toolbar
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu Terminal Developers: Pending requested
-
Diff: 123 lines (+53/-43)2 files modifiedtests/autopilot/ubuntu_terminal_app/tests/test_terminal.py (+2/-1)
ubuntu-terminal-app.qml (+51/-42)
Changed in ubuntu-terminal-app: | |
assignee: | nobody → Victor Thompson (vthompson) |
status: | New → In Progress |
Changed in ubuntu-filemanager-app: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-terminal-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I agree that a tab isn't the best place for Settings, but I do disagree that the toolbar is a better place or a good place whatsoever. A toolbar button should only be used for common, needed functionality that is relevant to the current view. I know that there are plans to access settings through the HUD, but for now I think a tab is the best place for Settings.
However, in the case of the File Manager, I want the tabs to be used for multiple file view tabs, like tabs in a desktop file manager. So I'm not sure what to do. I'll try to ask around about what should be done for now.