should handle boolean string parameters through migrate_live API
Bug #1257661 reported by
Ken'ichi Ohmichi
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Ken'ichi Ohmichi |
Bug Description
If specifying false string ("False") as "block_migration" parameter of migrate_live API like the following, nova considers it as True.
$ curl -i 'http://
On the other hand, nova can consider false string as false in the case of "on_shared_storage" parameter of evacuate API.
That behavior seems API inconsistency.
Changed in nova: | |
assignee: | nobody → Ken'ichi Ohmichi (oomichi) |
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
milestone: | none → icehouse-2 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-2 → 2014.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/59934 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=2e758452ddc b8871f7dbc6c859 e3414923cd18bc
Committed: https:/
Submitter: Jenkins
Branch: master
commit 2e758452ddcb887 1f7dbc6c859e341 4923cd18bc
Author: Ken'ichi Ohmichi <email address hidden>
Date: Wed Dec 4 14:21:34 2013 +0900
Add boolean convertors for migrate_live API
migrate_live API contains "block_migration" and "disk_over_commit" as
the parameters. They should be boolean.
There are the other boolean parameters such as "on_shared_storage" of
evacuate API, they can be passed with either boolean or string(e.g. "True").
For API consistency, this patch adds boolean convertors to migrate_live
API.
Change-Id: Ic3040811977c83 4bfd4b0b4527795 382e11227ed
Closes-Bug: #1257661