should handle boolean string parameters through migrate_live API

Bug #1257661 reported by Ken'ichi Ohmichi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Ken'ichi Ohmichi

Bug Description

If specifying false string ("False") as "block_migration" parameter of migrate_live API like the following, nova considers it as True.

$ curl -i 'http://10.21.42.81:8774/v2/[..]/servers/[..]/action' -X POST [..] -d '{"os-migrateLive": {"disk_over_commit": "False", "block_migration": "False", "host": "localhost"}}'

On the other hand, nova can consider false string as false in the case of "on_shared_storage" parameter of evacuate API.
That behavior seems API inconsistency.

Changed in nova:
assignee: nobody → Ken'ichi Ohmichi (oomichi)
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/59934
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2e758452ddcb8871f7dbc6c859e3414923cd18bc
Submitter: Jenkins
Branch: master

commit 2e758452ddcb8871f7dbc6c859e3414923cd18bc
Author: Ken'ichi Ohmichi <email address hidden>
Date: Wed Dec 4 14:21:34 2013 +0900

    Add boolean convertors for migrate_live API

    migrate_live API contains "block_migration" and "disk_over_commit" as
    the parameters. They should be boolean.
    There are the other boolean parameters such as "on_shared_storage" of
    evacuate API, they can be passed with either boolean or string(e.g. "True").
    For API consistency, this patch adds boolean convertors to migrate_live
    API.

    Change-Id: Ic3040811977c834bfd4b0b4527795382e11227ed
    Closes-Bug: #1257661

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.