Unshelving an instance uses original image not shelved image

[Sam Morrison]

When unshelving a shelved instance that has been offloaded to glance it doesn't actually use the image stored in glance.
It actually uses the image that the instance was booted up with in the first place.

This seems a bit crazy to me so it would be great if someone could replicate.

Note: This is with stable/havana but looking at master I don't see anything that would mean that this actually works in master either

Please tell me I'm wrong and I have some messed up setup......

[Russell Bryant (russellb)]

i haven't replicated but since sahid prioritized and assigned it to himself, i'm assuming he replicated it ...

[Sahid Orentino (sahid-ferdjaoui)]

I did the test on master, so I don't now for havana.

1. boot an instance cirros
2. connect myself to the instance and create a new file in /root directory
3. shelve + offload the instance
4. unshelve
5. connect myself to the instance and check for 'ok' in /root, but nothing

In the detail of the instance, we can see that the image used is not the snapshot create by the command shelve instance.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72407

[Sahid Orentino (sahid-ferdjaoui)]

The tempest test needs also to be fixed:

    https://review.openstack.org/#/c/74406/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72407
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=60455490c2c664dd41364ede29add64967a08844
Submitter: Jenkins
Branch: master

commit 60455490c2c664dd41364ede29add64967a08844
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Feb 10 17:12:30 2014 +0100

    Fix: Unshelving an instance uses original image

    The driver uses the property image_ref to boot the
    the instance.
    This patch updates the image_ref property with the
    shelved_image_id stored during the shelving.

    Change-Id: I3bba0a230044613e07122a6d122597e5b8d43438
    Closes-Bug: #1257594

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/81214

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/81214
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bd7ada265891d482100a111a4b578ce903fe14cc
Submitter: Jenkins
Branch: stable/havana

commit bd7ada265891d482100a111a4b578ce903fe14cc
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Feb 10 17:12:30 2014 +0100

    Fix: Unshelving an instance uses original image

    The driver uses the property image_ref to boot the
    the instance.
    This patch updates the image_ref property with the
    shelved_image_id stored during the shelving.

    Change-Id: I2304618bb5a995ea43f2a36069cfa0f3787c9792
    Closes-Bug: #1257594
    (cherry picked from commit 60455490c2c664dd41364ede29add64967a08844)