live migrate proceeds if the instance is locked

[Christopher Yeoh]

Locking an instance prevents normal migration from occurring, but does not prevent live migration. AFAICT there is no reason not to be consistent here and also stop live migration from occurring if the instance has been locked

[Matt Riedemann (mriedem)]

https://review.openstack.org/#/c/59614/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/59614
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=83e1f53a99dc504d95ccac29375dd38210c6acbf
Submitter: Jenkins
Branch: master

commit 83e1f53a99dc504d95ccac29375dd38210c6acbf
Author: Chris Yeoh <email address hidden>
Date: Tue Dec 3 15:01:23 2013 +1030

    Adds instance lock check for live migrate

    Whilst migrate has an instance locked check, live migrate didn't. This patch
    adds a check to see if the instance is locked in the compute api live migrate.

    Adds a testcase for V3 and generic instance lock checking for the V2 API since
    none existed yet.

    Closes-bug: 1257187

    Change-Id: I442abb74fe2a4d5d46b597b0ea24d249d2d03b45

[Matt Riedemann (mriedem)]

I think we have the same issue with snapshot:

http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py?id=2014.2.b1#n1950

[Matt Riedemann (mriedem)]

Oh nevermind this has already come up with snapshot:

http://lists.openstack.org/pipermail/openstack-dev/2014-June/037853.html

https://review.openstack.org/#/c/101972/