support conventional domain name with one or more dot

Bug #1257171 reported by wind dong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
wanghong

Bug Description

This is not a bug but a proposal.
Formal domain name will have one or more dot within the name, meantime, it's common for one company own several domains, for example abc.com and abc.net. If keystone with multi-domain support only supports domain name without '.', users will have to use abc_com and/or abc_net instead, which is not as good as to use abc.com and/or abc.net.
I made below little change to support conventional domain name use in /etc/keystone/domains/keystone.abc.com.conf and/or /etc/keystone/domains/keystone.abc.net.conf.

# diff core.py.orig core.py
125c125,127
< if len(names) == 3:
---
> if len(names) >= 3:
> for x in range(2,len(names)-1):
> names[1] += '.' + names[x]

Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Wishlist
wanghong (w-wanghong)
Changed in keystone:
assignee: nobody → wanghong (w-wanghong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79829

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/79829
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=de1b1073ddda3e8171cd5b11770b0eaa5035fd86
Submitter: Jenkins
Branch: master

commit de1b1073ddda3e8171cd5b11770b0eaa5035fd86
Author: wanghong <email address hidden>
Date: Tue Mar 11 20:27:03 2014 +0800

    support conventional domain name with one or more dot

    Formal domain name will have one or more dot within the name,
    meantime, it's common for one company own several domains,
    for example abc.com and abc.net. But currently keystone
    multi-domain support only supports domain name without '.',
    because the wrong way that get the domain name from domain
    config file name.

    Change-Id: I152cd3b513353e3d4c565e71c8755789d24e1a0e
    Closes-Bug: 1257171

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.