Validation passed when launching cluster with deleted flavors

[Alexander Ignatov]

Steps to reproduce:
1. Create some flavor in nova and remember its ID.
2. Remove created flavor.
3. Try to create cluster with node_group(s) using this deleted flavor ID.

Expected:
Validation Error with "Requested flavor 'ID' not found" message.

Actual result.
Savanna tries to create VM based on this flavor. And then "ERROR: Invalid flavorRef provided." during cluster provisioning.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59652

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/59652
Committed: http://github.com/openstack/savanna/commit/1fffce3bd7665cb20b7c822c9789c06edbda8d3f
Submitter: Jenkins
Branch: master

commit 1fffce3bd7665cb20b7c822c9789c06edbda8d3f
Author: Alexander Ignatov <email address hidden>
Date: Tue Dec 3 13:10:00 2013 +0400

    Fixed wrong flavor validation

    * Nova has designed feature that deleted flavor could be shown by its id.
    * Nova flavor list command doesn't show deleted flavors, so moved validation to check flavors in nova.flavors.list()
    * Updated appropriate unit tests

    Change-Id: I252c155f1d1f31bdacc4f2fc2e6f9da47ee05a38
    Closes-Bug: #1257019