tiff.c:847: possible bad if test ?

Bug #1256972 reported by dcb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Panotools
Fix Released
Undecided
Unassigned

Bug Description

I just ran the static analysis tool cppcheck over the source code
of libpano13-2.9.18. It said

[tiff.c:847] -> [tiff.c:847]: (style) Same expression on both sides of '||'.

Source code is

    if (metadata->xPixelsPerResolution == 0 || metadata->xPixelsPerResolution == 0)

Maybe

    if (metadata->xPixelsPerResolution == 0 || metadata->yPixelsPerResolution == 0)

might be better code.

Revision history for this message
tmodes (tmodes) wrote :

Thanks. Fixed in repository.

Changed in panotools:
status: New → Fix Committed
tmodes (tmodes)
Changed in panotools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.