headers with a value of None does not work anymore

[Chmouel Boudjnah]

Before commit 7d88d14d (https://github.com/openstack/python-swiftclient/commit/7d88d14def2541227fb4d3f96016a51b0bafa36b) swifclient would accept value of the type None :

{'Headers': None}

and would just not do anything on those None, now it crash when there is a value of None :

2013-11-29 11:25:43.911 ERROR heat.engine.resource [-] CREATE : SwiftContainer "SwiftContainer"
2013-11-29 11:25:43.911 TRACE heat.engine.resource Traceback (most recent call last):
2013-11-29 11:25:43.911 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 373, in _do_action
2013-11-29 11:25:43.911 TRACE heat.engine.resource handle_data = handle()
2013-11-29 11:25:43.911 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resources/swift.py", line 101, in handle_create
2013-11-29 11:25:43.911 TRACE heat.engine.resource self.swift().put_container(container, headers)
2013-11-29 11:25:43.911 TRACE heat.engine.resource File "/opt/stack/python-swiftclient/swiftclient/client.py", line 1185, in put_container
2013-11-29 11:25:43.911 TRACE heat.engine.resource response_dict=response_dict)
2013-11-29 11:25:43.911 TRACE heat.engine.resource File "/opt/stack/python-swiftclient/swiftclient/client.py", line 1113, in _retry
2013-11-29 11:25:43.911 TRACE heat.engine.resource rv = func(self.url, self.token, *args, **kwargs)
2013-11-29 11:25:43.911 TRACE heat.engine.resource File "/opt/stack/python-swiftclient/swiftclient/client.py", line 617, in put_container
2013-11-29 11:25:43.911 TRACE heat.engine.resource conn.request(method, path, '', headers)
2013-11-29 11:25:43.911 TRACE heat.engine.resource File "/opt/stack/python-swiftclient/swiftclient/client.py", line 167, in request_escaped
2013-11-29 11:25:43.911 TRACE heat.engine.resource validate_headers(headers)
2013-11-29 11:25:43.911 TRACE heat.engine.resource File "/opt/stack/python-swiftclient/swiftclient/client.py", line 102, in validate_headers
2013-11-29 11:25:43.911 TRACE heat.engine.resource if '\n' in value:
2013-11-29 11:25:43.911 TRACE heat.engine.resource TypeError: argument of type 'NoneType' is not iterable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59241

[Chmouel Boudjnah (chmouel)]

We probably don't want to store in heat headers as 'None'

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/59241
Committed: http://github.com/openstack/python-swiftclient/commit/983988093f3848671cb27b3c1956e4ca62087dff
Submitter: Jenkins
Branch: master

commit 983988093f3848671cb27b3c1956e4ca62087dff
Author: Chmouel Boudjnah <email address hidden>
Date: Fri Nov 29 22:59:27 2013 +0100

    Don't crash when header is value of None

    Before commit 7d88d14d (http://git.io/hhJWdQ) swifclient used to accept
    header value with the type None :

    {'Headers': None}

    It would just be happy with it with those None headers and not process
    them, reinstate the old behavior.

    Closes-Bug: 1256441
    Change-Id: Ic7f80c38ef2ce9ef1687ed0d6d65521f2e754905