Duplicate FlavorNotFound handled in server create API

[Matt Riedemann]

The FlavorNotFound exception is handled in multiple places in the server create API, the first being:

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L951

and the latter being:

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L970

They both return a 400 response and only the former is used, so remove the latter.

This is both in the v2 and v3 API.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59239

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/59239
Committed: http://github.com/openstack/nova/commit/2d2e30dba5c571c05dd4191c1b023fe4014c1751
Submitter: Jenkins
Branch: master

commit 2d2e30dba5c571c05dd4191c1b023fe4014c1751
Author: Matt Riedemann <email address hidden>
Date: Wed Nov 27 09:05:06 2013 -0800

    Remove duplicate FlavorNotFound exception handling in server create API

    The v2 and v3 openstack server create APIs have duplicate handling for
    the FlavorNotFound exception. This patch removes the duplicate handling
    which is found in a generic catch-all block for each API.

    Closes-Bug: #1256427

    Change-Id: I78344cd588178c501398147f3afcd418e0744b0d