Ironic

Get rid of __getitem__() and __setitem__() in Ironic object model.

Bug #1256260 reported by Mike Durnosvistov
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Wishlist
Unassigned

Bug Description

Currently unified object model supports dict-like behaviour of objects. This behaviour will be removed in the future so it's necessary to change Ironic's code to use object attributes as attributes but dictionary keys.

Mike Durnosvistov (glacierrdev)
Changed in ironic:
assignee: nobody → Mikhail Durnosvistov (mdurnosvistov)
Roman Prykhodchenko (romcheg)
Changed in ironic:
importance: Undecided → Low
status: New → Confirmed
Mike Durnosvistov (glacierrdev)
Changed in ironic:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60025

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/61776

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/62331

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/64108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/64251

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/64278

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/64336

OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Mikhail Durnosvistov (mdurnosvistov) → Devananda van der Veen (devananda)
Mike Durnosvistov (glacierrdev)
Changed in ironic:
assignee: Devananda van der Veen (devananda) → Mikhail Durnosvistov (mdurnosvistov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/64251
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=4542aca5fcb10b2c71912bbcce05ee0ccb36c4ed
Submitter: Jenkins
Branch: master

commit 4542aca5fcb10b2c71912bbcce05ee0ccb36c4ed
Author: Mikhail Durnosvistov <email address hidden>
Date: Fri Dec 27 05:50:46 2013 -0500

    Get rid object model `dict` methods part 4

    Currently unified object model supports dict-like behavior of objects.
    This behavior will be removed in the future so it's necessary to
    change Ironic's code to use object attributes as attributes instead of
    dictionary keys.

    This patch refactors usage of objects in `db` unit tests.

    Change-Id: Id7b3a35e7bec67f1b874df13d6e88660991c586f
    Partial-Bug: #1256260

aeva black (tenbrae)
Changed in ironic:
importance: Low → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/85065

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Mike Durnosvistov (<email address hidden>) on branch: master
Review: https://review.openstack.org/60025

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Mike Durnosvistov (<email address hidden>) on branch: master
Review: https://review.openstack.org/64108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Mike Durnosvistov (<email address hidden>) on branch: master
Review: https://review.openstack.org/62331

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Mike Durnosvistov (<email address hidden>) on branch: master
Review: https://review.openstack.org/64278

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Mike Durnosvistov (<email address hidden>) on branch: master
Review: https://review.openstack.org/85065

Revision history for this message
Dmitry Tantsur (divius) wrote :

Mikhail, is it correct to assume you no longer work on this bug?

Dmitry Tantsur (divius)
Changed in ironic:
status: In Progress → Triaged
assignee: Mike Durnosvistov (mdurnosvistov) → nobody
Revision history for this message
Ruby Loo (rloo) wrote :

I just opened a bug about replacing our object code with oslo.versionedobjects: https://bugs.launchpad.net/ironic/+bug/1461239

I don't know if this is still an issue in that library, but we shouldn't modify the object code in Ironic to try to address this.

Revision history for this message
Galyna Zholtkevych (gzholtkevych) wrote :

Is this issue still actual since
fix of bug https://bugs.launchpad.net/ironic/+bug/1461239 is released ?

Revision history for this message
Michael Turek (mjturek) wrote :

This bug is no longer valid as we've moved to the oslo.versionedobjects model

Changed in ironic:
status: Triaged → Won't Fix
status: Won't Fix → Incomplete
Michael Turek (mjturek)
Changed in ironic:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.