Trove not mocked in tests

Bug #1255936 reported by Radomir Dopieralski
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Cristian A Sanchez

Bug Description

When running tests, I get the following output on the console:

INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): public.trove.example.com
DEBUG:troveclient.client:Connection refused: HTTPConnectionPool(host='public.trove.example.com', port=8779): Max retries exceeded with url: /v1.0/instances/6ddc36d9-73db-4e23-b52e-368937d72719 (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)
..INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): public.trove.example.com
DEBUG:troveclient.client:Connection refused: HTTPConnectionPool(host='public.trove.example.com', port=8779): Max retries exceeded with url: /v1.0/instances/6ddc36d9-73db-4e23-b52e-368937d72719 (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): public.trove.example.com
DEBUG:troveclient.client:Connection refused: HTTPConnectionPool(host='public.trove.example.com', port=8779): Max retries exceeded with url: /v1.0/instances/4d7b3f57-44f5-41d2-8e86-36b88cad572a (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)

It seems like some calls to trove are not properly mocked in the tests, and it's trying to do actual calls.

Matthias Runge (mrunge)
Changed in horizon:
importance: Undecided → High
status: New → Triaged
milestone: none → icehouse-2
Changed in horizon:
assignee: nobody → Cristian A Sanchez (cristian-a-sanchez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60935

Changed in horizon:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/60935
Committed: http://github.com/openstack/horizon/commit/6afa1fdf1b660cf5932a0848f84a5262f26e3bb3
Submitter: Jenkins
Branch: master

commit 6afa1fdf1b660cf5932a0848f84a5262f26e3bb3
Author: Cristian A Sanchez <email address hidden>
Date: Mon Dec 9 12:23:28 2013 -0800

    Adds Trove mock to tests in database_backups

    Test cases in database_backups/tests.py now have a mock for the
    method api.trove.instance_get(). The absence of this mock was
    causing real HTTP requests to Trove.

    Change-Id: Icf760d7eaba2d136626dbbbbf6e49260a18fb874
    Closes-Bug: #1255936

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.