incorrect evaluation of members property
Bug #1255697 reported by
Stephen Gran
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Heat |
Fix Released
|
Undecided
|
Stephen Gran |
Bug Description
When evaluating an OS::Neutron:
This make constructs like
for member in self.properties
....
Fail, since what is returned is None rather than [], as self.properties has a key 'members' with a value of None.
The default should be changed to an empty array so that we don't have to keep guarding against None.
Changed in heat: | |
assignee: | nobody → Stephen Gran (sgran) |
status: | New → In Progress |
Changed in heat: | |
milestone: | none → icehouse-1 |
status: | Fix Committed → Fix Released |
Changed in heat: | |
milestone: | icehouse-1 → 2014.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/58797 github. com/openstack/ heat/commit/ a028cbe46cb22b0 50af3f3131dde86 55f6ebc852
Committed: http://
Submitter: Jenkins
Branch: master
commit a028cbe46cb22b0 50af3f3131dde86 55f6ebc852
Author: Stephen Gran <email address hidden>
Date: Wed Nov 27 15:40:47 2013 +0000
Ensure that members is a list
self. properties. get('members' ) should not be None. Ensure that
an empty list is returned instead.
Change-Id: I01d191eafebac3 0ad25505b312ff6 e936181bdbf
Closes-Bug: #1255697