Don't enable all stores by default

[Flavio Percoco]

Currently glance "tries" to load all stores even though the requirements are not meant. If a store cannot be loaded, it'll be disabled.

Although this is harmless, it is not user-friendly and creates some confusion when reading logs. Instead of trying to load and failing, glance should enable 2 stores by default - filesystem and http - and let the others be enabled manually by the user, which is what GridFS does.

TL;DR: The proposal is to remove all stores but file and http from here[0]

[0] https://git.openstack.org/cgit/openstack/glance/tree/glance/store/__init__.py#n39

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59150

[Sean Dague (sdague)]

This really should be fixed in glance, and honestly just make it so that stores aren't printing scary messages by default

[Sean Dague (sdague)]

Raising this issue to high because this ends up being a big scary issue in the glance logs all the time. And I think just some control over the way loading happened would clean up the glance logs a lot.

[Flavio Percoco (flaper87)]

Agreed and that's how it'll be done. Pls, see the Fix proposed for this bug (comment #1). We need the devstack patch anyway, I replied to your comment in the review.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/59150
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=1f6381a73f5c99f1f731d6c4f9defb91bd2d042d
Submitter: Jenkins
Branch: master

commit 1f6381a73f5c99f1f731d6c4f9defb91bd2d042d
Author: Flavio Percoco <email address hidden>
Date: Thu Nov 28 16:17:13 2013 +0100

    Don't enable all stores by default

    Glance currently enables all stores by default. This patch changes that
    by removing all stores that require manual configuration and leaving
    those that work right out of the box.

    Current behavior causes a lot of confusion to users since most of those
    stores print errors when they're not configured correctly. All extra
    stores should be enabled explicitly by users.

    This fix makes tests use http locations. All other locations besides the
    default ones should be tested in their own test suites.

    DocImpact
    Closes-bug: #1255556
    Change-Id: I82073352641d3eb2ab3d6e9a6b64afc99a30dcc7