Fuel for OpenStack

Status panel on UI should not show strange IP like [10.0.0.1] <error msg>

Bug #1255408 reported by Mike Scherbakov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Evgeniy L
Fuel for OpenStack 4.0

Bug Description

See screenshot. It shows error like
"[10.20.0.1] Node "Untitled (FB:F4) (id=5, mac=08:00:27:2D:FB:F4)" is offline. Remove it from environment and try again."

What is the purpose for [10.20.0.1]? Can we not to show it?

Revision history for this message
Mike Scherbakov (mihgen) wrote :
Changed in fuel:
milestone: none → 4.0
Vladimir Kuklin (vkuklin)
Changed in fuel:
assignee: nobody → Vitaly Kramskikh (vkramskikh)
Revision history for this message
Julia Aranovich (jkirnosova) wrote :

Should be fixed on backend side.

Changed in fuel:
assignee: Vitaly Kramskikh (vkramskikh) → Dmitry Pyzhov (lux-place)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Dmitry Pyzhov (lux-place) → Fuel Python Team (fuel-python)
Mike Scherbakov (mihgen)
tags: added: nailgun
Evgeniy L (rustyrobot)
tags: added: low-hanging-fruit
Revision history for this message
Evgeniy L (rustyrobot) wrote :

Need to remove useless parameter and code here

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/errors/base.py#L36

Also I think all of this parameters are useless too

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/errors/base.py#L25-L29

They can be removed and logging should be done on the level where we catch exceptions

Revision history for this message
Nikolay Markov (nmarkov) wrote :

Guys, let's discuss it one more time. This is not as obvious fix as it seems.

Changed in fuel:
status: New → Confirmed
Evgeniy L (rustyrobot)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Evgeniy L (rustyrobot)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62915

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/62915
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=d9c0e796c46b458022a783aeb2bf740ac4e5fc21
Submitter: Jenkins
Branch: master

commit d9c0e796c46b458022a783aeb2bf740ac4e5fc21
Author: Evgeniy L <email address hidden>
Date: Wed Dec 18 19:06:12 2013 +0400

    Remove IP address from error message

    * remove unused notify_user argument
    * remove add_client argument

    Closes-bug: #1255408
    Change-Id: I595626a704bc15b3c0123d550c94f622bdc068b5

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.