Fix InstanceIsLocked exception in server action

Bug #1255386 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
huangtianhua

Bug Description

We should catch the InstanceIsLocked exception in server actions which allow admins to operate.
Also V2 and V3 should be adjusted.

Changed in nova:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58665

Changed in nova:
status: New → In Progress
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Low
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/58665
Committed: http://github.com/openstack/nova/commit/1c6710a016b7dba18c4be799dd334565b0387448
Submitter: Jenkins
Branch: master

commit 1c6710a016b7dba18c4be799dd334565b0387448
Author: huangtianhua <email address hidden>
Date: Wed Nov 27 12:05:36 2013 +0800

    Catch InstanceIsLocked exception on server actions

    In v3, if the server is locked, a 409 error is raised, and the error msg
    is like "the server is locked". In v2 now, the 409 error is raised too. But the
    error msg is like "Instance is in an invalid state for \'pause(action name)\'".
    The error msg is inappropriate, two points:
    1. the state is valid for pause
    2. the message doesn't tell that the instance is locked

    The patch fixes the ploblem, and will do as v3. See the v3 commit:
    2c9fca6a3c916f3f594ddbb1a8ee8946b8ea3ac7

    Change-Id: I76572e37af686a4af35c31a3ea27f7070894b88a
    Closes-Bug: #1255386

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
tags: added: havana-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.