volume backed snapshots are NOT private by default

[Joel Cooklin]

Volume backed snapshots are NOT being set private ('is_public": False) by default.

Something similar to
https://github.com/openstack/nova/blob/e163d8293e82fd585d3579847d4e5368f401dce2/nova/compute/api.py#L1894

is needed around
https://github.com/openstack/nova/blob/e163d8293e82fd585d3579847d4e5368f401dce2/nova/compute/api.py#L1914

Documentation: http://docs.openstack.org/grizzly/openstack-compute/admin/content//cloudpipe-upload-image.html

[Joel Cooklin (joel-cooklin)]

The patch https://review.openstack.org/#/c/58629/ needs to be approved.

[Matt Fischer (mfisch)]

Even before the patch when I made snapshots of instances the Public flag is set to "No" by default, how did you repro this?

[Charles V Bock (charles-v-bock)]

@Matt Fischer

This bug is only reproducible when snapshotting a volume backed Instance.
If you use standard image based instances then you wont see the bug.

Were the ones you tested volume based? (boot from volume)?

[Matt Fischer (mfisch)]

@Charles:

No they were not. I'll try again with that.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58629
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0530e02004578a36039111beddf472fcf3e48df6
Submitter: Jenkins
Branch: master

commit 0530e02004578a36039111beddf472fcf3e48df6
Author: jcooklin <email address hidden>
Date: Tue Nov 26 14:33:47 2013 -0700

    Set is_public to False by default for volume backed snapshots

    This update results in the same behavior that is already implemented
    in _create_image where the meta_data for is_public is set to False.

    Change-Id: Ie0720d5c847871527db7d9477ca6cb05abe7a1a5
    Closes-Bug: #1255316

[Matt Riedemann (mriedem)]

Around the time this merged (1/17), we started seeing bug 1270608 in the gate. So I'm wondering if the change introduced a race condition somehow.

[Matt Riedemann (mriedem)]

@Joel, were you using glance v1 or v2 API when you tested this?

[Matt Riedemann (mriedem)]

Also, which cinder API and what backends for glance and cinder?

[Joel Cooklin (joel-cooklin)]

@mriedem glance v2 with ceph backing both glance and cinder

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/112662

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112662
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5d2b9576cb29465ff99f127d5fc1c5a2f3a0651c
Submitter: Jenkins
Branch: stable/havana

commit 5d2b9576cb29465ff99f127d5fc1c5a2f3a0651c
Author: jcooklin <email address hidden>
Date: Tue Nov 26 14:33:47 2013 -0700

    Set is_public to False by default for volume backed snapshots

    This update results in the same behavior that is already implemented
    in _create_image where the meta_data for is_public is set to False.

    Change-Id: Ie0720d5c847871527db7d9477ca6cb05abe7a1a5
    Closes-Bug: #1255316
    (cherry picked from commit 0530e02004578a36039111beddf472fcf3e48df6)